Skip to content

Conversation

@aphillips
Copy link
Member

Create the acknowledgements section. Addresses #711. See that issue for how this was created (although it is self-describing).

Additional names are welcome! Specific acknowledgements for specific deeds are also welcome (as mentioned in the 2024-03-18 call). No omission is intentional. Don't feel shy about putting your name on our work.

@aphillips aphillips added documentation Improvements or additions to documentation fast-track Editorial change permitted to use fast-track merge rules specification Issue affects the specification LDML45 labels Mar 19, 2024
Co-authored-by: Tim Chevalier <[email protected]>
## Acknowledgements

Special thanks to the following people for their contributions to making MessageFormat v2.
The following people contributed to our github repo and are listed in order by contribution size:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this may have a bit of a skew caused by the fact that git commits are not the only way people have participated. Is there maybe a way to also count the number of issue/pr comments?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fair. Note that this also counts issues.

I could alphabetize by family name. The idea of organizing by what github gives us it that is provides some weighting for "participation" without trying to reconstruct specific contributions. I could also look back at meeting minutes to see if we're missing someone.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You make a good point: once we decide to use something other than what GitHub gives us by default, we're in the business of making it as close to the true representation of participation as possible, and that's very hard to do right.

I think it's OK to merge this as-is.

@macchiati
Copy link
Member

Just a note: we typically let people specify a native script version of their names in parentheses. If anyone wants that, I suggest a follow-on PR.

@aphillips aphillips merged commit beab981 into main Mar 25, 2024
@aphillips aphillips deleted the aphillips-acknowledgements branch March 25, 2024 16:47
@eemeli eemeli added this to the LDML 45 milestone Jul 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation fast-track Editorial change permitted to use fast-track merge rules specification Issue affects the specification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants